-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for FlexPRET platform #412
Conversation
I believe this PR now is ready for review :) |
One change I made that probably affects other platforms too: I added EDIT: This caused Zephyr CI tests to fail, so removed this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This generally looks very good. I left some comments/questions.
Thank you for the review! I'm on vacation until Friday, so there will be much less work on my end until then, just so you know. Might do a little work here and there :) |
Hmm, no jobs were run... Do you know what the issue might be @lhstrh? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks mostly good, but I dont like that platform-specific details are creeping out of low-level-platform
@erlingrj I fixed all concerns now. I was able to fix the underlying issue that made me add the platform-specific code in util.c and tracepoint.h in the first place (#412 (comment)). Only thing is I don't exactly understand why just the first test runs... EDIT: Right, I was referencing a file that does not exist in the main LF repo yet |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. If you want to run CI with a specific branch of lingua-franca, then write the branch name into lingua-franca-ref.txt
. Before we merge we modify back to master
Hmm, the ref thing does not seem to work since my branch is on a fork as well... I can change to URL (lf-lang/lingua-franca/.github/workflows/c-flexpret-tests.yml@master) to point to my fork as well though, i.e., magnmaeh/lingua-franca/.github/workflows/c-flexpret-tests.yml@add-flexpret-support, which is valid. But that file depends on lots of other files again and fails. Maybe its better to just try and resolve any CI issues in the main repo PR instead? |
Yes, when CI passes in the PR of |
Let me push out one more patch release before merging this. |
This PR adds support for the FlexPRET platform.